Skip to content

Create unified Bitcoin design principles page - #144

Merged
pavlenex merged 100 commits into
masterfrom
feature/principles
Mar 25, 2021
Merged

pavlenex merged 100 commits into
masterfrom
feature/principles

Conversation

@danielnordh

@danielnordh danielnordh commented Feb 12, 2021 •

Copy link
Copy Markdown
Contributor

Adds new page for unified principles following issue #116.

Todo:

  • Get feedback and reviews of page content
  • Make sure nav order of all (other) pages are correct
  • Remove Principles from Private Key Management chapter
  • Check links to/from other pages in the guide

@danielnordh danielnordh changed the title Draft - Create new principles folder and page Draft - Create new principles page Feb 12, 2021

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid list and principles. Some early light feedback.

Comment thread guide/principles/principles.md Resolved
@danielnordh danielnordh changed the title Draft - Create new principles page Create new principles page Feb 12, 2021
@danielnordh
danielnordh marked this pull request as ready for review February 12, 2021 11:30
@danielnordh danielnordh changed the title Create new principles page Create new unified Bitcoin design principles page Feb 12, 2021
@danielnordh danielnordh changed the title Create new unified Bitcoin design principles page Create unified Bitcoin design principles page Feb 12, 2021
@danielnordh danielnordh added the Copy Task is about improving text. label Feb 15, 2021
Comment thread guide/principles/principles.md Resolved
Comment thread guide/principles/principles.md Resolved
Comment thread guide/principles/principles.md Resolved
Comment thread guide/principles/principles.md Resolved
Comment thread guide/principles/principles.md Resolved
Comment thread guide/principles/principles.md Resolved
danielnordh and others added 11 commits March 19, 2021 13:14
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a final look at the content in-depth. Structure-wise, great work, and I think you included the most important principles and emphasized their importance.

I've suggested a few minor typos and grammar-related fixes I've noticed, as well as 2-3 attempts to simplify the structure of the sentence, which is up to you to accept or ignore, it's just a personal preference.

Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
Comment thread guide/foundations/principles.md Resolved
danielnordh and others added 10 commits March 24, 2021 09:29
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>
Co-authored-by: Pavlenex <pavlenex@btcpayserver.org>

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

This one is good to get merged IMO 🚀

@GBKS

GBKS commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

tACK.

Two small follow-up tasks I can think of:

  • Add more visuals to represent the different principles (sounds like a fun and challenging exercise)
  • Cross-link to principles from various sub-pages

@pavlenex
pavlenex merged commit ba96df2 into master Mar 25, 2021
@pavlenex

Copy link
Copy Markdown
Contributor

@danielnordh @GBKS For the follow-up tasks, if you'd like we can open a separate issue to keep a track of it.

🚀 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a "Principles" page in "Foundations"

5 participants